fix(storage): add samples for bucket encryption encoforcement config by bajajneha27 · Pull Request #16045 · googleapis/google-cloud-cpp

bajajneha27 · 2026-03-16T06:38:36Z

No description provided.

gemini-code-assist · 2026-03-16T06:38:52Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces new C++ samples for the Google Cloud Storage client library, specifically focusing on managing bucket encryption enforcement configurations. These examples provide practical demonstrations of how to programmatically interact with and control the encryption policies for storage buckets, covering operations like retrieving current settings, applying new enforcement rules, and clearing existing configurations.

Highlights

New C++ Sample Added: A new C++ example file, storage_bucket_encryption_enforcement_samples.cc, has been added to demonstrate how to manage bucket encryption enforcement configurations.
Encryption Enforcement Operations: The new sample includes functions to retrieve, set, and remove Google-managed, customer-managed, and customer-supplied encryption key enforcement policies for Google Cloud Storage buckets.
Build System Integration: The new sample has been integrated into both the CMake and Bazel build systems, ensuring it is discoverable and buildable within the storage_examples project.

Changelog

google/cloud/storage/examples/CMakeLists.txt
- Added storage_bucket_encryption_enforcement_samples.cc to the list of example sources.
google/cloud/storage/examples/storage_bucket_encryption_enforcement_samples.cc
- Added a new C++ file containing samples for getting, setting, and removing bucket encryption enforcement configurations.
google/cloud/storage/examples/storage_examples.bzl
- Added storage_bucket_encryption_enforcement_samples.cc to the storage_examples list.

Activity

No human activity (comments, reviews, etc.) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request adds new samples for managing bucket encryption enforcement configurations. The changes are well-structured and the new sample code correctly demonstrates the usage of the API. All original comments have been retained as they align with general C++ best practices and the Google C++ Style Guide, and none of the provided rules contradict them.

gemini-code-assist · 2026-03-16T06:47:54Z

google/cloud/storage/examples/storage_bucket_encryption_enforcement_samples.cc

+  std::cout << "\nCreating bucket to run the example (" << bucket_name << ")"
+            << std::endl;


Per the Google C++ Style Guide, you should use \n instead of std::endl. std::endl also flushes the stream, which is often unnecessary and can impact performance.

std::cout << "\nCreating bucket to run the example (" << bucket_name << ")\n";

References

The repository style guide defers to the Google C++ Style Guide, which states to use \n instead of std::endl to avoid performance issues with flushing the stream. ^(link)

gemini-code-assist · 2026-03-16T06:47:54Z

google/cloud/storage/examples/storage_bucket_encryption_enforcement_samples.cc

+  std::cout << "\nRunning the SetBucketEncryptionEnforcementConfig() example"
+            << std::endl;


Per the Google C++ Style Guide, you should use \n instead of std::endl. std::endl also flushes the stream, which is often unnecessary and can impact performance.

std::cout << "\nRunning the SetBucketEncryptionEnforcementConfig() example\n";

References

The repository style guide defers to the Google C++ Style Guide, which states to use \n instead of std::endl to avoid performance issues with flushing the stream. ^(link)

gemini-code-assist · 2026-03-16T06:47:54Z

google/cloud/storage/examples/storage_bucket_encryption_enforcement_samples.cc

+  std::cout << "\nRunning the GetBucketEncryptionEnforcementConfig() example [1]"
+            << std::endl;


Per the Google C++ Style Guide, you should use \n instead of std::endl. std::endl also flushes the stream, which is often unnecessary and can impact performance.

std::cout << "\nRunning the GetBucketEncryptionEnforcementConfig() example [1]\n";

References

The repository style guide defers to the Google C++ Style Guide, which states to use \n instead of std::endl to avoid performance issues with flushing the stream. ^(link)

gemini-code-assist · 2026-03-16T06:47:54Z

google/cloud/storage/examples/storage_bucket_encryption_enforcement_samples.cc

+  std::cout << "\nRunning the RemoveAllEncryptionEnforcementConfig() example"
+            << std::endl;


Per the Google C++ Style Guide, you should use \n instead of std::endl. std::endl also flushes the stream, which is often unnecessary and can impact performance.

std::cout << "\nRunning the RemoveAllEncryptionEnforcementConfig() example\n";

References

The repository style guide defers to the Google C++ Style Guide, which states to use \n instead of std::endl to avoid performance issues with flushing the stream. ^(link)

gemini-code-assist · 2026-03-16T06:47:54Z

google/cloud/storage/examples/storage_bucket_encryption_enforcement_samples.cc

+  std::cout << "\nRunning the GetBucketEncryptionEnforcementConfig() example [2]"
+            << std::endl;


Per the Google C++ Style Guide, you should use \n instead of std::endl. std::endl also flushes the stream, which is often unnecessary and can impact performance.

std::cout << "\nRunning the GetBucketEncryptionEnforcementConfig() example [2]\n";

References

The repository style guide defers to the Google C++ Style Guide, which states to use \n instead of std::endl to avoid performance issues with flushing the stream. ^(link)

codecov · 2026-03-16T07:48:45Z

Codecov Report

❌ Patch coverage is 94.95798% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.68%. Comparing base (d60f99e) to head (28ac203).

Files with missing lines	Patch %	Lines
...s/storage_bucket_encryption_enforcement_samples.cc	95.61%	5 Missing ⚠️
google/cloud/storage/bucket_metadata.cc	80.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16045      +/-   ##
==========================================
- Coverage   92.68%   92.68%   -0.01%     
==========================================
  Files        2342     2343       +1     
  Lines      216537   216626      +89     
==========================================
+ Hits       200700   200782      +82     
- Misses      15837    15844       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

v-pratap · 2026-03-26T11:44:19Z

google/cloud/storage/examples/storage_bucket_encryption_enforcement_samples.cc

+    // For the update, need to specify all three configs, so keeping this same
+    // as before
+    encryption.customer_supplied_encryption_enforcement_config
+        .restriction_mode = "FullyRestricted";


on line number 149, we write encryption = original->encryption();
Wouldn't this be enough?

I'm sorry I didn't follow. What would not be enough?

product-auto-label bot added api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples. labels Mar 16, 2026

gemini-code-assist bot reviewed Mar 16, 2026

View reviewed changes

bajajneha27 force-pushed the bucket-encryption-sample branch 2 times, most recently from 4fac04b to aefe810 Compare March 24, 2026 16:20

bajajneha27 added 8 commits March 25, 2026 04:33

samples(storage): add samples for bucket encryption encoforcement config

461480e

update sample as per latest requirement

6dd903e

fix ci failure

ad542ce

fix ci failures

fcb79c4

fix ci failures

253ddfb

change the bucket name

0284884

fix ci failures

6efc34d

fix ci failures

6216fdb

bajajneha27 force-pushed the bucket-encryption-sample branch from 5b15454 to 6216fdb Compare March 25, 2026 05:57

fix ci failures

28ac203

bajajneha27 marked this pull request as ready for review March 25, 2026 06:48

bajajneha27 requested review from a team as code owners March 25, 2026 06:48

bajajneha27 requested a review from nidhiii-27 March 26, 2026 05:15

bajajneha27 changed the title ~~samples(storage): add samples for bucket encryption encoforcement config~~ fix(storage): add samples for bucket encryption encoforcement config Mar 26, 2026

v-pratap approved these changes Mar 26, 2026

View reviewed changes

nidhiii-27 approved these changes Mar 27, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(storage): add samples for bucket encryption encoforcement config#16045

fix(storage): add samples for bucket encryption encoforcement config#16045
bajajneha27 wants to merge 9 commits intogoogleapis:mainfrom
bajajneha27:bucket-encryption-sample

bajajneha27 commented Mar 16, 2026

Uh oh!

gemini-code-assist bot commented Mar 16, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Mar 16, 2026

Uh oh!

gemini-code-assist bot Mar 16, 2026

Uh oh!

gemini-code-assist bot Mar 16, 2026

Uh oh!

gemini-code-assist bot Mar 16, 2026

Uh oh!

gemini-code-assist bot Mar 16, 2026

Uh oh!

codecov bot commented Mar 16, 2026 •

edited

Loading

Uh oh!

v-pratap Mar 26, 2026

Uh oh!

bajajneha27 Mar 27, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		std::cout << "\nCreating bucket to run the example (" << bucket_name << ")"
		<< std::endl;

		std::cout << "\nRunning the SetBucketEncryptionEnforcementConfig() example"
		<< std::endl;

		std::cout << "\nRunning the GetBucketEncryptionEnforcementConfig() example [1]"
		<< std::endl;

		std::cout << "\nRunning the RemoveAllEncryptionEnforcementConfig() example"
		<< std::endl;

Conversation

bajajneha27 commented Mar 16, 2026

Uh oh!

gemini-code-assist bot commented Mar 16, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

v-pratap Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

bajajneha27 Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Mar 16, 2026 •

edited

Loading

bajajneha27 Mar 27, 2026 •

edited

Loading